Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Move to go modules #1821

Merged
merged 5 commits into from Jan 23, 2020
Merged

Move to go modules #1821

merged 5 commits into from Jan 23, 2020

Conversation

chenrui333
Copy link
Contributor

Fixes #1807

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 5, 2020
@chenrui333 chenrui333 changed the title Go modules Move to go modules Jan 5, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign danielfm
You can assign the PR to them by writing /assign @danielfm in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 5, 2020
@chenrui333
Copy link
Contributor Author

Circle back on the PR.

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 20, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 20, 2020
@codecov-io
Copy link

codecov-io commented Jan 20, 2020

Codecov Report

Merging #1821 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1821   +/-   ##
=======================================
  Coverage   24.59%   24.59%           
=======================================
  Files          98       98           
  Lines        5071     5071           
=======================================
  Hits         1247     1247           
  Misses       3684     3684           
  Partials      140      140

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ffe330...93dc806. Read the comment docs.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 20, 2020
@chenrui333
Copy link
Contributor Author

chenrui333 commented Jan 20, 2020

Remove vendor folder in favor of go modules to manage the dependencies.

https://research.swtch.com/vgo-module

The End of Vendoring
Vendor directories serve two purposes. First, they specify by their contents the exact version of the dependencies to use during gobuild. Second, they ensure the availability of those dependencies, even if the original copies disappear. On the other hand, vendor directories are also difficult to manage and bloat the repositories in which they appear. With the go.mod file specifying the exact version of dependencies to use during vgo build, and with proxy servers for ensuring availability, vendor directories are now almost entirely redundant. They can, however, serve one final purpose: to enable a smooth transition to the new versioned world.

When building a module, vgo (and later go) will completely ignore vendored dependencies; those dependencies will also not be included in the module's zip file. To make it possible for authors to move to vgo and go.mod while still supporting users who haven't converted, the new vgo vendorcommand populates a module's vendor directory with the packages users need to reproduce the vgo-based build.

@davidmccormick davidmccormick merged commit b6e6901 into kubernetes-retired:master Jan 23, 2020
@davidmccormick
Copy link
Contributor

Many thanks for this super useful contribution! 🙏

@davidmccormick davidmccormick added this to the v0.16.0 milestone Feb 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move to go modules
4 participants