-
Notifications
You must be signed in to change notification settings - Fork 295
Fix for #1823 #1824
Fix for #1823 #1824
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @sei-nicolas! |
[Signed CLA] |
Codecov Report
@@ Coverage Diff @@
## master #1824 +/- ##
=======================================
Coverage 24.59% 24.59%
=======================================
Files 98 98
Lines 5071 5071
=======================================
Hits 1247 1247
Misses 3684 3684
Partials 140 140 Continue to review full report at Codecov.
|
Hi it's still not coming up as signed - can you take another look at signing it? Many thanks! |
Can you also alter your commit message to remove the fixes #1823 from it? This isn't allowed by our repository manager bot, sorry! |
this changes cluster.yaml initial skeleton to avoid the use of Config as input
5e1199c
to
f556d6c
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sorry for the CLA, I had missed one step. And changed for the commit text (I had actually tried to use the template in https://github.com/kubernetes-incubator/kube-aws/blob/master/CONTRIBUTING.md and could not understand what was the rejected character) Hope that works. |
This looks great thanks! Thanks very much for working on this issue and solution! 🙏 Would you please also PR your commit against out v0.15.x branch please? Then I'll create a release containing your fix - many thanks! |
Sure, PR 1827. |
This changes cluster.yaml initial skeleton to avoid the use of (not available) Config struct