Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Fix for #1823 #1824

Merged

Conversation

sei-nicolas
Copy link
Contributor

This changes cluster.yaml initial skeleton to avoid the use of (not available) Config struct

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jan 22, 2020
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 22, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @sei-nicolas!

It looks like this is your first PR to kubernetes-incubator/kube-aws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-incubator/kube-aws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 22, 2020
@sei-nicolas
Copy link
Contributor Author

[Signed CLA]

@codecov-io
Copy link

codecov-io commented Jan 22, 2020

Codecov Report

Merging #1824 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1824   +/-   ##
=======================================
  Coverage   24.59%   24.59%           
=======================================
  Files          98       98           
  Lines        5071     5071           
=======================================
  Hits         1247     1247           
  Misses       3684     3684           
  Partials      140      140

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ffe330...f556d6c. Read the comment docs.

@davidmccormick
Copy link
Contributor

Hi it's still not coming up as signed - can you take another look at signing it? Many thanks!

@davidmccormick
Copy link
Contributor

Can you also alter your commit message to remove the fixes #1823 from it? This isn't allowed by our repository manager bot, sorry!

@davidmccormick davidmccormick self-assigned this Jan 23, 2020
this changes cluster.yaml initial skeleton to avoid the use of Config as input
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 23, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign davidmccormick
You can assign the PR to them by writing /assign @davidmccormick in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sei-nicolas
Copy link
Contributor Author

Sorry for the CLA, I had missed one step.

And changed for the commit text (I had actually tried to use the template in https://github.com/kubernetes-incubator/kube-aws/blob/master/CONTRIBUTING.md and could not understand what was the rejected character)

Hope that works.

@davidmccormick
Copy link
Contributor

This looks great thanks! Thanks very much for working on this issue and solution! 🙏 Would you please also PR your commit against out v0.15.x branch please? Then I'll create a release containing your fix - many thanks!

@davidmccormick davidmccormick merged commit 55e9e81 into kubernetes-retired:master Jan 23, 2020
@sei-nicolas
Copy link
Contributor Author

Sure, PR 1827.

@davidmccormick davidmccormick added this to the v0.16.0 milestone Feb 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants