Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Move from the old m3.medium instance type to the marginally better t2.medium #184

Merged
merged 1 commit into from Jan 6, 2017

Conversation

mumoshu
Copy link
Contributor

@mumoshu mumoshu commented Dec 27, 2016

ref #181

@mumoshu mumoshu added this to the v0.9.3-rc.3 milestone Dec 27, 2016
@codecov-io
Copy link

codecov-io commented Dec 27, 2016

Current coverage is 69.11% (diff: 100%)

Merging #184 into master will not change coverage

@@             master       #184   diff @@
==========================================
  Files             4          4          
  Lines          1130       1130          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            781        781          
  Misses          261        261          
  Partials         88         88          

Powered by Codecov. Last update 639829c...0a925c8

@pieterlange
Copy link
Contributor

-1 Lets not use t2 for controllers by default - you should really know what you're doing when using this instance class.

Also, 4GB of memory seems a bit on the low side when you start actually using the cluster. My not keep the m3.medium and suggest to use m4.large or t2.large?

@mumoshu
Copy link
Contributor Author

mumoshu commented Dec 27, 2016

@pieterlange Thanks for your feedback here!

I believe setting good defaults and moving away from the old m3.medium instance type are separate things. So:

  • Would you please read my comment about that? To be more clear, It's true that I began to believe t2.medium is better than m3.medium but I'm not opposed to make m4.large or t2.large by default.

  • Also, if you have any concrete advice on choosing which instance type(s) as default(s), I'd appreciate it if you could read about my suggestions and reply with your suggestions on the instance type for etcd, controller and worker nodes 👍

@mumoshu mumoshu changed the title Move from the deprecated m3.medium instance type to the marginally better t2.medium Move from the old m3.medium instance type to the marginally better t2.medium Dec 28, 2016
@mumoshu
Copy link
Contributor Author

mumoshu commented Dec 28, 2016

Changing the subject according to what we've discussed in #181 (comment)

@mumoshu
Copy link
Contributor Author

mumoshu commented Jan 6, 2017

Things seems to be left up in the air but I'm going to merge this to get the ball rolling 🙇

Let's discuss further about better default(s) in #181

@mumoshu mumoshu merged commit 7d98698 into kubernetes-retired:master Jan 6, 2017
@mumoshu mumoshu deleted the m3-is-deprecated branch January 6, 2017 02:24
kylehodgetts pushed a commit to HotelsDotCom/kube-aws that referenced this pull request Mar 27, 2018
Move from the old m3.medium instance type to the marginally better t2.medium
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants