Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

[v0.14.x] Allow use of PodAutoscalerUseRestClient without addon metrics-server. #1844

Merged
merged 1 commit into from
Apr 30, 2020
Merged

[v0.14.x] Allow use of PodAutoscalerUseRestClient without addon metrics-server. #1844

merged 1 commit into from
Apr 30, 2020

Conversation

dominicgunn
Copy link
Contributor

Changes

  • Allows us to enable --horizontal-pod-autoscaler-use-rest-clients without requiring us to use the metrics-server addon.

@dominicgunn dominicgunn added this to the v0.14.5 milestone Apr 30, 2020
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 30, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign dominicgunn
You can assign the PR to them by writing /assign @dominicgunn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 30, 2020
@codecov-io
Copy link

codecov-io commented Apr 30, 2020

Codecov Report

Merging #1844 into v0.14.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           v0.14.x    #1844   +/-   ##
========================================
  Coverage    24.93%   24.93%           
========================================
  Files           98       98           
  Lines         5078     5078           
========================================
  Hits          1266     1266           
  Misses        3673     3673           
  Partials       139      139           
Impacted Files Coverage Δ
pkg/api/types.go 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b42b9a...65d91c6. Read the comment docs.

@dominicgunn dominicgunn merged commit 1a3509a into kubernetes-retired:v0.14.x Apr 30, 2020
@dominicgunn dominicgunn deleted the feature/v0.14.x-enable-pod-autoscaler branch April 30, 2020 11:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants