Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

[v0.16.0] make flannel subnetLen configurable for big clusters #1848

Conversation

Fsero
Copy link
Contributor

@Fsero Fsero commented May 1, 2020

We had an issue in a big cluster (around 200 nodes) when rolling upgrade a change and replacing instances we ran out of subnet leases, that causes that new workers were unable to get a flannel lease and hence setting up the network and were killed due to not sending the cfn-signal in time.

This patch aims to make subnetLen configurable for big clusters, using kube-aws default flannel config the maximum is 255 nodes which means around 127 nodes and a rolling upgrade that replaces all instances (like updating the base AMI).

In the case of being unset, flanneld will keep using the default which is /24 per node.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign redbaron
You can assign the PR to them by writing /assign @redbaron in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 1, 2020
@Fsero Fsero force-pushed the make_flannel_leases_configurable branch from edf6ec1 to 24492f7 Compare May 1, 2020 10:44
@codecov-io
Copy link

Codecov Report

Merging #1848 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1848      +/-   ##
==========================================
- Coverage   24.41%   24.40%   -0.01%     
==========================================
  Files          98       98              
  Lines        5116     5117       +1     
==========================================
  Hits         1249     1249              
- Misses       3727     3728       +1     
  Partials      140      140              
Impacted Files Coverage Δ
pkg/api/cluster.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c59afae...24492f7. Read the comment docs.

@dominicgunn
Copy link
Contributor

This is awesome, we have the same issue! Thank you.

@dominicgunn
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2020
@dominicgunn dominicgunn added this to the v0.16.0 milestone May 4, 2020
@dominicgunn dominicgunn merged commit 198de8a into kubernetes-retired:master May 4, 2020
@dominicgunn dominicgunn changed the title make flannel subnetLen configurable for big clusters [v0.16.0] make flannel subnetLen configurable for big clusters May 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants