Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

[v0.16.0] Switch kubernetes.io/cluster/X tag value to "owned". #1858

Merged
merged 1 commit into from
May 27, 2020

Conversation

dominicgunn
Copy link
Contributor

Changes

Having these values as "true" causes stack drift, as we later update them to be "owned". In order to ensure we don't needlessly roll pools we should update the CloudFormation so that "owned" is the expected value.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 26, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign dominicgunn
You can assign the PR to them by writing /assign @dominicgunn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 26, 2020
@dominicgunn dominicgunn added this to the v0.16.0 milestone May 26, 2020
@codecov-commenter
Copy link

codecov-commenter commented May 26, 2020

Codecov Report

Merging #1858 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1858   +/-   ##
=======================================
  Coverage   24.40%   24.40%           
=======================================
  Files          98       98           
  Lines        5117     5117           
=======================================
  Hits         1249     1249           
  Misses       3728     3728           
  Partials      140      140           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdc0325...a0204a4. Read the comment docs.

@dominicgunn
Copy link
Contributor Author

/lgtm

@k8s-ci-robot
Copy link
Contributor

@dominicgunn: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dominicgunn dominicgunn merged commit 7b6e648 into master May 27, 2020
@mumoshu mumoshu deleted the feature/v0.16.0-kubernetes.io-cluster-tags branch May 28, 2020 11:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants