[v0.16.x] Setup Calico Networking Option #1872
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XXL
| @@ -387,7 +382,8 @@ coreos: | |||
| {{- end }} | |||
| $KUBELET_OPTS" | |||
| Restart=always | |||
| RestartSec=10 | |||
| RestartSec=10 | |||
|
|
|||
There was a problem hiding this comment.
I actually added this purposefully to more clearly separate the [Service] and [Install] block similar to other unit definitions here.
We should probably unify on one in another pull request (extra line between unit blocks, or without extra line), what are your thoughts?
There was a problem hiding this comment.
Sorry for the late response. I'm ok with the extra line but maybe would be much cleared if we use gotmpl comments
| RestartSec=10 | |
| {{/* END of kubelet [Service] */}} |
There was a problem hiding this comment.
I'm happy with that, I pushed those changes up.
|
Hi @dominicgunn thanks for your efforts and the contribution. I was looking into Calico docs and didn't see any official information about canal deprecation. Can you share for better context? Thanks! |
Path based access has been deprecated and now returns a redirect error to bucketname.s3.amazonaws.com as explained in this post: https://aws.amazon.com/blogs/aws/amazon-s3-path-deprecation-plan-the-rest-of-the-story/ This makes cloudformation to fail as it refers to the now redirected s3 bucket path, and raises the message: S3 error: The bucket you are attempting to access must be addressed using the specified endpoint. Please send all future requests to this endpoint. For more information check http://docs.aws.amazon.com/AmazonS3/latest/API/ErrorResponses.html There is no strong documentation about what are the updates in China and Gov regions, consider it follows the same logic. Change-Id: I9f8bbc47801b120c216d24de701855073506c89c
Migrate to new s3 URL method
Codecov Report
@@ Coverage Diff @@
## v0.16.x #1872 +/- ##
===========================================
- Coverage 24.41% 24.40% -0.01%
===========================================
Files 98 98
Lines 5116 5117 +1
===========================================
Hits 1249 1249
- Misses 3727 3728 +1
Partials 140 140
Continue to review full report at Codecov.
|
|
Removed myself for review since unfortunately at the moment I don't have an appropriate stack available to check through this. |
k8s-ci-robot
added
the
do-not-merge/invalid-commit-message
|
Keywords which can automatically close issues and at(@) mentions are not allowed in commit messages. The list of commits with invalid commit messages: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
kubeletto self labelkubernetes.iotags, making nodes difficult to differentiate.