Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

[v0.15.0] Switch CoreOS to Flatcar #1879

Merged
merged 3 commits into from Jul 2, 2020
Merged

[v0.15.0] Switch CoreOS to Flatcar #1879

merged 3 commits into from Jul 2, 2020

Conversation

flah00
Copy link
Contributor

@flah00 flah00 commented Jul 1, 2020

Changes

* use Flatcar in the v0.15.x branch, shamelessly stolen from @jorge07 and @dominicgunn, thanks!
@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign redbaron
You can assign the PR to them by writing /assign @redbaron in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 1, 2020
@jorge07
Copy link
Contributor

jorge07 commented Jul 1, 2020

You'll need to modify the unit for disabled auto updates. I've it in my 0.12 branch but need to prepare a PR

@flah00
Copy link
Contributor Author

flah00 commented Jul 1, 2020

@jorge07 I am not familiar with the unit you're talking about. Can you fill me in? :)

@jorge07
Copy link
Contributor

jorge07 commented Jul 1, 2020

Sure. Here the original pr #1241 and here the reference for the new OS https://docs.flatcar-linux.org/os/update-strategies/#disable-automatic-updates-daemon

@k8s-ci-robot
Copy link
Contributor

Keywords which can automatically close issues and at(@) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

  • a198f90 [v0.15.0] Switch CoreOS to Flatcar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jorge07
Copy link
Contributor

jorge07 commented Jul 1, 2020

Great work!

@flah00
Copy link
Contributor Author

flah00 commented Jul 1, 2020

Thanks for your help!

@dominicgunn
Copy link
Contributor

Super sorry we missed this, thanks for contributing.

@dominicgunn
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2020
@dominicgunn dominicgunn merged commit 566f54b into kubernetes-retired:v0.15.x Jul 2, 2020
@dominicgunn dominicgunn added this to the v0.15.3 milestone Jul 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants