Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Handle error from ReadOrCreateEncryptedTLSAssets gracefully. #188

Merged
merged 1 commit into from Jan 3, 2017
Merged

Handle error from ReadOrCreateEncryptedTLSAssets gracefully. #188

merged 1 commit into from Jan 3, 2017

Conversation

andrejvanderzee
Copy link
Contributor

Causes panic when ReadOrCreateEncryptedTLSAssets, for example when you enter a bad kmsKeyArn.

Ever considered using Dave Cheney's error package?
https://dave.cheney.net/2016/04/27/dont-just-check-errors-handle-them-gracefully

@codecov-io
Copy link

codecov-io commented Dec 31, 2016

Current coverage is 68.99% (diff: 0.00%)

Merging #188 into master will decrease coverage by 0.12%

@@             master       #188   diff @@
==========================================
  Files             4          4          
  Lines          1130       1132     +2   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            781        781          
- Misses          261        262     +1   
- Partials         88         89     +1   

Powered by Codecov. Last update dec2402...7f62a74

@mumoshu
Copy link
Contributor

mumoshu commented Jan 3, 2017

@andrejvanderzee Thanks as always! LGTM 👍

Regarding the which error package to introduce into kube-aws, I have not yet considered Dave Cheney's one. FYI, reqs for an error package for kube-aws in my mind are supports for (1) nested errors and (2) stack traces for each nested error, and my preference so far is juju/errors. I'm open to suggestion(s) though.

@mumoshu mumoshu merged commit 2b29fc3 into kubernetes-retired:master Jan 3, 2017
@mumoshu mumoshu added this to the v0.9.3-rc.3 milestone Jan 6, 2017
kylehodgetts pushed a commit to HotelsDotCom/kube-aws that referenced this pull request Mar 27, 2018
Handle error from ReadOrCreateEncryptedTLSAssets gracefully.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants