Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

[v0.16.x] Fix etcd certificates when using private zones #1893

Merged

Conversation

dominicgunn
Copy link
Contributor

Changes

The AWS Cloud Controller does not support private zones, so if you use it with etcd >=v2.4..5 then you will run into issues with cluster initialization, because of a feature introduced the does a reverse dns look up to ensure the IP making requests matches a host on the certificate SANs.

Worse, even if you add all reverse zones so that this does work with your private zone, the aws controller does not name nodes after your private zone, and they instead come up using .compute.internal nodeNames. This causes problem elsewhere in the kube-aws stack where we try to update nodes using hostname, but in this scenario hostname != nodename. (*.myprivate.zone vs *...compute.internal).

This is a hack that allowed us to move forward, but a better implementation is needed & should be revisited.

…e aws controller does not support private zones
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 1, 2020
@cknowles cknowles removed their request for review August 3, 2020 02:52
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign dominicgunn
You can assign the PR to them by writing /assign @dominicgunn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 13, 2020
@dominicgunn dominicgunn added this to the v0.16.3 milestone Aug 13, 2020
@dominicgunn dominicgunn merged commit b06335b into kubernetes-retired:v0.16.x Aug 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants