Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Documentation and validation for too long IAM role names #443

Merged

Conversation

mumoshu
Copy link
Contributor

@mumoshu mumoshu commented Mar 23, 2017

Closes #347

@mumoshu mumoshu added this to the v0.9.5-rc.6 milestone Mar 23, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 23, 2017
@codecov-io
Copy link

Codecov Report

Merging #443 into master will increase coverage by 0.14%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master     #443      +/-   ##
==========================================
+ Coverage   40.87%   41.02%   +0.14%     
==========================================
  Files          37       38       +1     
  Lines        2669     2679      +10     
==========================================
+ Hits         1091     1099       +8     
- Misses       1419     1420       +1     
- Partials      159      160       +1
Impacted Files Coverage Δ
cfnresource/naming.go 100% <100%> (ø)
core/controlplane/config/config.go 63.83% <50%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0eef4f2...68439d1. Read the comment docs.

@mumoshu mumoshu merged commit 1f08f3b into kubernetes-retired:master Mar 23, 2017
@mumoshu mumoshu deleted the validate-iam-role-name-len branch March 23, 2017 08:50
kylehodgetts pushed a commit to HotelsDotCom/kube-aws that referenced this pull request Mar 27, 2018
…ole-name-len

Documentation and validation for too long IAM role names
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants