Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Fix quote on "Launch the secondary node" #626

Merged
merged 1 commit into from
May 11, 2017

Conversation

velo
Copy link
Contributor

@velo velo commented May 7, 2017

No description provided.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 7, 2017
@codecov-io
Copy link

Codecov Report

Merging #626 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #626   +/-   ##
======================================
  Coverage    37.7%   37.7%           
======================================
  Files          51      51           
  Lines        3302    3302           
======================================
  Hits         1245    1245           
  Misses       1854    1854           
  Partials      203     203

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7db8629...15e660f. Read the comment docs.

@mumoshu
Copy link
Contributor

mumoshu commented May 7, 2017

Good catch, @velo!
I'll merge this asap after you signed the CLA.

@velo
Copy link
Contributor Author

velo commented May 11, 2017

I'm trying to, but doesn't seem to be that simple

screen shot 2017-05-11 at 12 08 38 pm

@mumoshu
Copy link
Contributor

mumoshu commented May 11, 2017

@velo Thanks. The same access denied error appears to me, too 😅
What do you see after navigating via theMy Account link in your capture?
For me, it looks like:

image

and I wish you could see any link to sign the CLA there.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 11, 2017
@velo
Copy link
Contributor Author

velo commented May 11, 2017

Looks it's all good now, thanks

@mumoshu
Copy link
Contributor

mumoshu commented May 11, 2017

@velo Thanks for taking your time 👍

@mumoshu mumoshu merged commit 0502776 into kubernetes-retired:master May 11, 2017
@mumoshu mumoshu added this to the v0.9.7-rc.1 milestone May 11, 2017
kylehodgetts pushed a commit to HotelsDotCom/kube-aws that referenced this pull request Mar 27, 2018
Fix quote on "Launch the secondary node"
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants