Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Fix unable to backup namespaced resources #632

Merged
merged 1 commit into from
May 10, 2017

Conversation

cheungpat
Copy link
Contributor

The kube-resources-autosave script is unable to find the list of namespaces
and so it tries to backup resources from null namespace.

Log from kube-resources-autosave-dumper:

(...snip...)
++ jq -r .metadata.name
+ for ns in '$(jq -r '\''.metadata.name'\'' < ${DUMP_DIR}/namespaces.json)'
+ echo 'Searching in namespace: null'
+ mkdir -p /kube-resources-autosave/tmp/2017-05-09_15-18-57/null
Searching in namespace: null
(...snip...)

The kube-resources-autosave script is unable to find the list of namespaces
and so it tries to backup resources from `null` namespace.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 9, 2017
@jollinshead
Copy link
Contributor

@cheungpat Nice find 👍 LGTM

@codecov-io
Copy link

Codecov Report

Merging #632 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #632   +/-   ##
=======================================
  Coverage   38.26%   38.26%           
=======================================
  Files          51       51           
  Lines        3316     3316           
=======================================
  Hits         1269     1269           
  Misses       1845     1845           
  Partials      202      202

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6b5d5e...9eb24c0. Read the comment docs.

@mumoshu
Copy link
Contributor

mumoshu commented May 10, 2017

Good catch 👍 Thanks for the fix @cheungpat!

@mumoshu mumoshu merged commit 22d737b into kubernetes-retired:master May 10, 2017
kylehodgetts pushed a commit to HotelsDotCom/kube-aws that referenced this pull request Mar 27, 2018
Fix unable to backup namespaced resources
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants