This repository has been archived by the owner on Sep 30, 2020. It is now read-only.
Fixes #630 leading slash on s3:prefix removed to fix ListObject permi… #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x ListObject permission denied error during etcdadm save
k8s-ci-robot
added
the
cncf-cla: yes
Codecov Report
@@ Coverage Diff @@
## master #634 +/- ##
=======================================
Coverage 38.26% 38.26%
=======================================
Files 51 51
Lines 3316 3316
=======================================
Hits 1269 1269
Misses 1845 1845
Partials 202 202
Continue to review full report at Codecov.
|
mumoshu
reviewed
May 10, 2017
| @@ -124,8 +124,8 @@ func (c *StackConfig) EtcdSnapshotsS3PrefixRef() (string, error) { | |||
| if err != nil { | |||
| return "", fmt.Errorf("Error in EtcdSnapshotsS3Prefix : %v", err) | |||
| } | |||
| s3path := fmt.Sprintf(`{ "Fn::Join" : [ "", [ "%s/instances/", { "Fn::Select" : [ "2", { "Fn::Split": [ "/", { "Ref": "AWS::StackId" }]} ]}, "/etcd-snapshots" ]]}`, s3uri.Path) | |||
| return strings.TrimLeft(s3path, "/"), nil | |||
|
@jeremyd LGTM. Thanks as always for your support 👍 |
kylehodgetts
pushed a commit
to HotelsDotCom/kube-aws
that referenced
this pull request
Mar 27, 2018
Fixes kubernetes-retired#630 leading slash on s3:prefix removed to fix ListObject permi…
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ssion denied error during etcdadm save.