This repository has been archived by the owner on Sep 30, 2020. It is now read-only.
Use new K8S 1.6 AWS tagging scheme #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
KubernetesCluster is deprecated in favour of `kubernetes.io/cluster/$NAME`
redbaron
force-pushed
the
new-tagging-scheme
branch
from
b69e59d
to
5f60607
Compare
Codecov Report
@@ Coverage Diff @@
## master #652 +/- ##
=======================================
Coverage 38.26% 38.26%
=======================================
Files 51 51
Lines 3316 3316
=======================================
Hits 1269 1269
Misses 1845 1845
Partials 202 202Continue to review full report at Codecov.
|
|
Thanks for the improvement @redbaron! |
|
@mumoshu , yes, based on the code in https://github.com/kubernetes/kubernetes/blob/release-1.6/pkg/cloudprovider/providers/aws/tags.go |
|
@redbaron Thanks. LGTM 👍 |
kylehodgetts
pushed a commit
to HotelsDotCom/kube-aws
that referenced
this pull request
Mar 27, 2018
…ng-scheme Use new K8S 1.6 AWS tagging scheme
ketzacoatl
added a commit
to fpco/terraform-aws-foundation
that referenced
this pull request
Apr 24, 2018
This is the new tag, replacing the deprecated `KubernetesCluster`. See kubernetes-retired/kube-aws#652 for additional info.
ketzacoatl
added a commit
to fpco/terraform-aws-foundation
that referenced
this pull request
May 1, 2018
This is the new tag, replacing the deprecated `KubernetesCluster`. See kubernetes-retired/kube-aws#652 for additional info.
ketzacoatl
added a commit
to fpco/terraform-aws-foundation
that referenced
this pull request
May 1, 2018
This is the new tag, replacing the deprecated `KubernetesCluster`. See kubernetes-retired/kube-aws#652 for additional info.
ketzacoatl
added a commit
to fpco/terraform-aws-foundation
that referenced
this pull request
May 1, 2018
This is the new tag, replacing the deprecated `KubernetesCluster`. See kubernetes-retired/kube-aws#652 for additional info.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KubernetesCluster is deprecated in favour of
kubernetes.io/cluster/$NAME