This repository has been archived by the owner on Sep 30, 2020. It is now read-only.
Make kubelet flags more consistent #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that kubelet silently converts `cluster_dns` into `cluster-dns`, so nothing was broken, it is just a minor cleanup
k8s-ci-robot
added
the
cncf-cla: yes
Codecov Report
@@ Coverage Diff @@
## master #663 +/- ##
=======================================
Coverage 37.42% 37.42%
=======================================
Files 50 50
Lines 3177 3177
=======================================
Hits 1189 1189
Misses 1812 1812
Partials 176 176Continue to review full report at Codecov.
|
|
@redbaron Good catch 👍 Thanks for the fix! |
kylehodgetts
pushed a commit
to HotelsDotCom/kube-aws
that referenced
this pull request
Mar 27, 2018
…et-flags Make kubelet flags more consistent
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that kubelet silently converts
cluster_dnsintocluster-dns, so nothing was broken, it is just a minor cleanup