Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Fix "install-kube-system" script when "clusterAutoscaler" is disabled. #671

Merged
merged 1 commit into from
May 22, 2017

Conversation

camilb
Copy link
Contributor

@camilb camilb commented May 22, 2017

Hi @mumoshu it looks that leaving the

  clusterAutoscaler:
    enabled: false

will break the "install-kube-system" script. This is the error in journald:

May 22 13:42:19 ip-10-0-1-49.ec2.internal install-kube-system[16493]: error: the path "/srv/kubernetes/manifests/cluster-autoscaler-de.yaml" does not exist

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 22, 2017
@codecov-io
Copy link

Codecov Report

Merging #671 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #671   +/-   ##
======================================
  Coverage    37.1%   37.1%           
======================================
  Files          52      52           
  Lines        3210    3210           
======================================
  Hits         1191    1191           
  Misses       1842    1842           
  Partials      177     177

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0504707...22dfeb3. Read the comment docs.

@mumoshu
Copy link
Contributor

mumoshu commented May 22, 2017

@camilb Ah, my bad. Thanks a lot for the fix!
I will cut rc.2 with the fix asap.

@mumoshu mumoshu merged commit a6f2c33 into kubernetes-retired:master May 22, 2017
@camilb camilb deleted the fix-ca branch May 22, 2017 14:44
@mumoshu mumoshu added this to the v0.9.7-rc.2 milestone May 24, 2017
kylehodgetts pushed a commit to HotelsDotCom/kube-aws that referenced this pull request Mar 27, 2018
Fix "install-kube-system" script when "clusterAutoscaler" is disabled.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants