This repository has been archived by the owner on Sep 30, 2020. It is now read-only.
Enhance cluster.yaml documentation #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ytsarev
commented
Jun 13, 2017
ytsarev
commented
- Change confusing example for controller nodeLabels
- Remove outdated and scary statement for rbac enablement
* Change confusing example for controller nodeLabels * Remove outdated and scary statement for rbac enablement
k8s-ci-robot
added
the
cncf-cla: yes
Codecov Report
@@ Coverage Diff @@
## master #700 +/- ##
=======================================
Coverage 35.31% 35.31%
=======================================
Files 53 53
Lines 3047 3047
=======================================
Hits 1076 1076
Misses 1802 1802
Partials 169 169Continue to review full report at Codecov.
|
|
@ytsarev Thanks for the good catch 👍 |
kylehodgetts
pushed a commit
to HotelsDotCom/kube-aws
that referenced
this pull request
Mar 27, 2018
Enhance cluster.yaml documentation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.