Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Report errors if empty nodepool is specified #718

Merged

Conversation

redbaron
Copy link
Contributor

Fixes #714

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 29, 2017
@codecov-io
Copy link

Codecov Report

Merging #718 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #718   +/-   ##
=======================================
  Coverage   34.33%   34.33%           
=======================================
  Files          55       55           
  Lines        3073     3073           
=======================================
  Hits         1055     1055           
  Misses       1859     1859           
  Partials      159      159

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c67b469...edc8337. Read the comment docs.

@redbaron redbaron merged commit afaf0a3 into kubernetes-retired:master Jun 30, 2017
@redbaron redbaron deleted the error-on-empty-nodepool branch June 30, 2017 12:03
@redbaron
Copy link
Contributor Author

Change is small enough for self-merge :)

@mgreenwald-pm
Copy link

@redbaron Thanks!

@mumoshu mumoshu modified the milestone: v0.9.7 Jul 5, 2017
kylehodgetts pushed a commit to HotelsDotCom/kube-aws that referenced this pull request Mar 27, 2018
…empty-nodepool

Report errors if empty nodepool is specified
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants