Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Add critical-pod annotation to CA #724

Merged

Conversation

mumoshu
Copy link
Contributor

@mumoshu mumoshu commented Jul 3, 2017

Resolves #683

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 3, 2017
@redbaron redbaron merged commit b478d0d into kubernetes-retired:master Jul 3, 2017
@redbaron
Copy link
Contributor

redbaron commented Jul 3, 2017

Don't we need to have tolerations [{"key":"CriticalAddonsOnly", "operator":"Exists"}] specified there as well?

mumoshu added a commit to mumoshu/kube-aws that referenced this pull request Jul 5, 2017
@mumoshu mumoshu deleted the critical-pod-annotation-on-ca branch July 5, 2017 23:27
@mumoshu
Copy link
Contributor Author

mumoshu commented Jul 5, 2017

@redbaron Thanks! Just submitted a follow-up PR for that at #738

@mumoshu mumoshu modified the milestone: v0.9.7 Jul 5, 2017
camilb added a commit to camilb/kube-aws that referenced this pull request Aug 1, 2017
* kubernetes-incubator/master:
  Update heapster k8s manifests accordingly to the upstream
  Add cluster kube-aws version to outputs
  Refactor code to reside in WithDefaultsFrom()
  Update go used to build the E2E container image to 1.8.3 to fix a build error
  Update Kubernetes to v1.7.0 Closes kubernetes-retired#744
  Update CA to 0.6.0 Closes kubernetes-retired#725
  Install Tiller by default Closes kubernetes-retired#656
  Update golang to v1.8.3 Closes kubernetes-retired#720
  Update the default etcd version to 3.2.1 Closes kubernetes-retired#726
  Update OWNERS
  Inject stack name  into userdata for nodepool workers (kubernetes-retired#735)
  Add CA a CriticalAddonsOnly toleration Ref kubernetes-retired#724
  Update comment in cluster.yaml
  Drain node on spot instance termination notice as well
  Additional propagation of etcd version for etcdadm#722)
  Bugfix: CloudWatchLogging always disabled for Worker nodes
  Update ROADMAP.md
kylehodgetts pushed a commit to HotelsDotCom/kube-aws that referenced this pull request Mar 27, 2018
…nnotation-on-ca

Add critical-pod annotation to CA
kylehodgetts pushed a commit to HotelsDotCom/kube-aws that referenced this pull request Mar 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants