Remove createRecordSet to help newcomers bring up their first clusters
#936
Conversation
k8s-ci-robot
added
cncf-cla: yes
Codecov Report
@@ Coverage Diff @@
## master #936 +/- ##
========================================
Coverage ? 35.3%
========================================
Files ? 58
Lines ? 4019
Branches ? 0
========================================
Hits ? 1419
Misses ? 2442
Partials ? 158
Continue to review full report at Codecov.
|
|
looks like it is renaming |
|
@redbaron Yes and no 👍 It turned out that we need a config key to allow one to force creation of LB even though one didn't specify any key other than that. CreateRecordSet has also Basically, RecordSetManaged has fewer meanings and a better default than CreateRecordSet. |
|
/lgtm |
|
@redbaron Thanks for reviewing 🍻 |
…w-kube-aws to hcom-flavour * commit '13aa1d1b0569f21304545c005c5da9f810a41b66': (41 commits) Continue to allow `system:nodes` to act as `system:node-proxier` Rename cluster, user, context to 'default' Use localhost instead of 127.0.0.1 Add comment Use service account token in master kube-proxies Address review points Convert kube-proxy to a DaemonSet Add in missing ASG IAM permission for experimental.nodeDrainer. Support deployment to AWS GovCloud Update kubedns Only add CIDR from NLB-backed endpoints to controller SG Fixes kubernetes-retired#946 Support drop-ins in customSystemdUnits Remove tests for constraints that are no longer true Add support for apiAccessAllowedSourceCIDRs to NLB-backed endpoints Use correct predicate function Fix logic to check whether the load balancer is a NLB Add support for NLB-backed API endpoints Bump default k8s to 1.7.6 Fixes kubernetes-retired#942 etcdadm cannot find ca.pem Remove `createRecordSet` to help newcomers bring up their first clusters (kubernetes-retired#936) ...
|
5cdb74e#diff-971c12e3b00cffb1d084e6e1f5942103R99 There should not be a check for nil in e.RecordSetManaged |
|
I could be a good idea add this change to I found that issue digging into issues after look at release notes and it should be the opposite. Anyway its works ;) |
…ers (kubernetes-retired#936) by preventing the Route53 misconfiguration. The --hosted-zone-id flag and the corresponding hostedZone.id key in cluster.yaml are now required by default. You can explicitly omit them by setting --no-record-set or recordSetManaged: false. This way, one can't omit hosted zone id without knowing the implication of omitting the hosted zone id. Resolves kubernetes-retired#928 Changelog: * HostedZone ID is required by default in cluster.yaml * --hosted-zone-id is required by default when running `kube-aws init`
by preventing the Route53 misconfiguration.
The
--hosted-zone-idflag and the correspondinghostedZone.idkey in cluster.yaml are now required by default. You can explicitly omit them by setting--no-record-setorrecordSetManaged: false. This way, one can't omit hosted zone id without knowing the implication of omitting the hosted zone id.Resolves #928