Skip to content
This repository has been archived by the owner on May 22, 2020. It is now read-only.

machine-controller: update Machine.Status when appropriate #349

Closed
pipejakob opened this issue Nov 7, 2017 · 6 comments
Closed

machine-controller: update Machine.Status when appropriate #349

pipejakob opened this issue Nov 7, 2017 · 6 comments
Labels
cluster-api help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@pipejakob
Copy link
Contributor

So far, it doesn't update the Machine's Status at all.
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 7, 2018
@karan
Copy link
Contributor

karan commented Feb 7, 2018

From what I understand we are not going to be using Status. @jessicaochen - please reopen if you think there is a future use for Status.

@karan
Copy link
Contributor

karan commented Feb 7, 2018

/close

@jessicaochen
Copy link
Contributor

Let's make this issue more clear, we should make sure that the Ready & LastUpdated field on the MachineStatus is getting updated by the machine controller. (Or removed from the status if it does not add value)

I know that the NodeRef and error messages are already being populated.

@jessicaochen jessicaochen reopened this Feb 7, 2018
@jessicaochen jessicaochen added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Feb 7, 2018
@rsdcastro
Copy link

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 7, 2018
@rsdcastro rsdcastro mentioned this issue Apr 12, 2018
Closed
@rsdcastro
Copy link

This issue was moved to kubernetes-sigs/cluster-api#9

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
cluster-api help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@rsdcastro @pipejakob @karan @k8s-ci-robot @jessicaochen @fejta-bot