Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

machine-controller: update Machine.Status when appropriate #9

Closed
rsdcastro opened this issue Apr 12, 2018 · 5 comments
Closed

machine-controller: update Machine.Status when appropriate #9

rsdcastro opened this issue Apr 12, 2018 · 5 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@rsdcastro
Copy link

From @pipejakob on November 7, 2017 20:8

So far, it doesn't update the Machine's Status at all.

Copied from original issue: kubernetes-retired/kube-deploy#349
@rsdcastro rsdcastro added cluster-api help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Apr 12, 2018
@rsdcastro
Copy link
Author

From @fejta-bot on February 7, 2018 16:32

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@rsdcastro
Copy link
Author

From @karan on February 7, 2018 17:21

From what I understand we are not going to be using Status. @jessicaochen - please reopen if you think there is a future use for Status.

@rsdcastro
Copy link
Author

From @karan on February 7, 2018 17:21

/close

@rsdcastro
Copy link
Author

From @jessicaochen on February 7, 2018 18:4

Let's make this issue more clear, we should make sure that the Ready & LastUpdated field on the MachineStatus is getting updated by the machine controller. (Or removed from the status if it does not add value)

I know that the NodeRef and error messages are already being populated.

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 12, 2018
@rsdcastro
Copy link
Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 12, 2018
@rsdcastro rsdcastro mentioned this issue Apr 12, 2018
Closed
jayunit100 pushed a commit to jayunit100/cluster-api that referenced this issue Jan 31, 2020
@sidharthsurana @k8s-ci-robot
Add support for specifying vsphere credentials via secrets (kubernete…
b5ce311 
…s-sigs#250)

- Adds new field vsphereCredentialSecret that can be specified to
  point to the secret that holds the credentials

Resolves kubernetes-sigs#9

Change-Id: I8e43864302a51386f7f11725b0a966cc9e436c59
vivek-koppuru pushed a commit to vivek-koppuru/cluster-api that referenced this issue Jan 24, 2022
@mrajashree
Merge pull request kubernetes-sigs#9 from vivek-koppuru/mrajashree-br…
cb4a45d 
…anch-release-1.0

Add status.version to list of fields to ignore for update
killianmuldoon referenced this issue in killianmuldoon/cluster-api Mar 28, 2022
@sbueringer
implement catalog (#9)
e8c5968
killianmuldoon referenced this issue in killianmuldoon/cluster-api Mar 29, 2022
@sbueringer @killianmuldoon
implement catalog (#9)
cc987da
ahreehong pushed a commit to ahreehong/cluster-api that referenced this issue Jan 11, 2023
@jiayiwang7
Merge pull request kubernetes-sigs#9 from jiayiwang7/etcd-health-check
d07e6a6 
Mark etcd machine status to running after etcd controller adds the etcd machine ready label
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rsdcastro @k8s-ci-robot