Use the cluster name in cluster.yaml in admin.conf #636
Comments
|
cc @jessicaochen @rsdcastro - If no objections, I can start to look into this. |
|
It does make sense to me. |
|
Seems like the cluster name is hardcoded in kubeadm: There's been a PR to make it configurable, but it's been stale: kubernetes/kubernetes#52470 |
|
Perhaps we can work on a new PR that focus on the cluster name to avoid the contention on the other point (user admins)? |
|
I may be wrong but I think it is just the name in the kubeconfig file to reference the cluster. If you change the name in the kubeconfig file or set a new one with the name your want (https://kubernetes-v1-4.github.io/docs/user-guide/kubectl/kubectl_config_set-cluster/), you can still address the same cluster. In that way, it really does not matter what kubeadm happens to dump as the cluster name on the master. |
|
You are right @jessicaochen. I tried this with |
|
I guess it depends on how important urgent this change is. Whether we want to wait for kubeadm to do it or we want an interim solution. |
|
/label cluster-api |
|
As a prototype we could live with managing a single cluster (or doing something hacky), but at least for an alpha/MVP, a good approach is to support cluster names. I've already sent them a PR for it. |
|
This issue was moved to kubernetes-sigs/cluster-api#49 |
Automatic merge from submit-queue (batch tested with PRs 58178, 62491, 60852). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. [kubeadm] Add support for clusterName in config file. **What this PR does / why we need it**: Adds a `--cluster-name` arg to kubeadm init. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: See kubernetes-retired/kube-deploy#636 Code inspired by #52470 **Special notes for your reviewer**: **Release note**: ```release-note Adds --cluster-name to kubeadm init for specifying the cluster name in kubeconfig. ```
Currently the cluster config is created with cluster name as
kubernetes. There is a cluster name in thecluster.yamlmetadata.name. We should start using that name for the cluster so tools can be made to target any cluster in kubeconfig file.The text was updated successfully, but these errors were encountered: