This repository has been archived by the owner on May 22, 2020. It is now read-only.
Update messages on service account to be explicit about GCP service account #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
k8s-ci-robot
added
the
size/S
|
/assign medinatiger |
k8s-ci-robot
added
the
approved
medinatiger
reviewed
Feb 6, 2018
| ) | ||
|
|
||
| const ( | ||
| ServiceAccountPrefix = "k8s-machine-controller-" | ||
| ServiceAccount = "service-account" | ||
| MachineControllerSecret = "machine-controller-credential" | ||
| ServiceAccountNs = "kube-system" |
There was a problem hiding this comment.
This should be sth configurable in the future. It doesn't mean you should change this. Just FYI
There was a problem hiding this comment.
Agreed! Filed to track it: #573
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medinatiger, rsdcastro The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k4leung4
pushed a commit
to k4leung4/kube-deploy
that referenced
this pull request
Apr 4, 2018
…ce-account-message Update messages on service account to be explicit about GCP service account
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.