This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
Workaround ns version handling issue #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
font
reviewed
Apr 29, 2018
| // TODO(marun) Need to revisit how namespace deletion affects | ||
| // the version cache. Ignoring may cause some unnecessary | ||
| // updates, but that's better than looping endlessly. | ||
| if kind != federatedtypes.NamespaceKind { |
There was a problem hiding this comment.
There is federatedtypes.IsNameSpaceKind() if this ends up being used beyond just as a workaround.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I traced #64 to the version cache. I'll pursue a proper fix on Monday, but disabling the check for namespaces fixes the problem (at the cost of potentially performing some unnecessary updates).
cc: @font @onyiny-ang