Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

Fix retain replicas field type (was bool, should be boolean) #698

Merged
merged 2 commits into from
Mar 28, 2019
Merged

Fix retain replicas field type (was bool, should be boolean) #698

merged 2 commits into from
Mar 28, 2019

Conversation

marun
Copy link
Contributor

@marun marun commented Mar 27, 2019

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 27, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 27, 2019
@marun
Copy link
Contributor Author

marun commented Mar 27, 2019

@shashidharatd This bug was discovered in testing against openshift (based on kube 1.13), and reveals that our use of an old version of kubebuilder has also influenced the version of kube-apiserver that we are testing against in a managed test run (since we source it from the kubebuilder archive and the version we use supplies 1.12). This adds motivation to keeping pace with kubebuilder releases so that we're not testing against an old version of kube (either that or we start sourcing kube-apiserver somewhere else). I've also filed an issue (#699) to track updating CI to use a more recent release of kube (likely 1.13 until kind and kubebuilder update to 1.14).

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 28, 2019
@shashidharatd
Copy link
Contributor

Thanks @marun for the fix.
Agree with keeping pace with projects which we depend on.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2019
@k8s-ci-robot k8s-ci-robot merged commit 9c92282 into kubernetes-retired:master Mar 28, 2019
@marun marun deleted the fix-retain-replicas branch April 24, 2019 23:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants