This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
if FTC is not same version/group, reject request #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
|
Note that the group/version here is for the federated type CRD. As per #804, changing the group/version of the target should be supported as a way of 'upgrading' the API that is targeted in member clusters. |
|
This is really a code error. I fixed it. |
marun
reviewed
Apr 30, 2019
k8s-ci-robot
added
needs-rebase
k8s-ci-robot
removed
the
needs-rebase
marun
reviewed
May 7, 2019
|
Thank you! /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marun, xunpan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #743
if FTC exists, ensure that the group and version of the crd that will be generated match what exists (so it can update instead of creating a new one)
If group and version don't match - error.