Merge pull request #917 from adrianludwin/unbreak-114-051

Unbreak object validator on 1.14
kubernetes-retired · Jul 23, 2020 · e6946d0 · e6946d0
2 parents 78ecff5 + 162841f
commit e6946d0
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/incubator/hnc/internal/validators/object.go b/incubator/hnc/internal/validators/object.go
@@ -70,6 +70,10 @@ func (o *Object) Handle(ctx context.Context, req admission.Request) admission.Re
 		}
 	}
 	if req.Operation != admissionv1beta1.Create {
+		// See issue #688 and #889
+		if req.Operation == admissionv1beta1.Delete && req.OldObject.Raw == nil {
+			return allow("cannot validate deletions in K8s 1.14")
+		}
 		if err := o.decoder.DecodeRaw(req.OldObject, oldInst); err != nil {
 			log.Error(err, "Couldn't decode req.OldObject", "raw", req.OldObject)
 			return deny(metav1.StatusReasonBadRequest, err.Error())