HNC: compile the plugin for Mac

[adrianludwin]

Todo: add the appropriate flags to the makefile, and then update cloudbuild.yaml to rebuild the plugin for multiple OSes.

[adrianludwin]

/good-first-issue

[tcnksm]

Since we want to have this, let me try to contribute this!

[adrianludwin]

This is now fixed on master. I'll backport to 0.5.2.

[adrianludwin]

/remove-good-first-issue
/assign @adrianludwin

[adrianludwin]

Fixed by #1049
/close

[k8s-ci-robot]

@adrianludwin: Closing this issue.

In response to this:

Fixed by #1049
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[adrianludwin]

/reopen
/assign @tcnksm

Hi Taichi, can you please verify that HNC v0.5.2 RC1 works for you - both the YAML files but also the Darwin plugin? I don't have any ability to test on MacOS. Thanks!

[k8s-ci-robot]

@adrianludwin: Reopened this issue.

In response to this:

/reopen
/assign @tcnksm

Hi Taichi, can you please verify that HNC v0.5.2 RC1 works for you - both the YAML files but also the Darwin plugin? I don't have any ability to test on MacOS. Thanks!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tcnksm]

Hi Taichi, can you please verify that HNC v0.5.2 RC1 works for you - both the YAML files but also the Darwin plugin? I don't have any ability to test on MacOS. Thanks!

Ok. Let me confirm those.

Darwin plugin

I've executed the following command by following the release note instruction.

$ HNC_VERSION=v0.5.2-rc1
$ HNC_PLATFORM=darwin_amd64
$ $ curl -L https://github.com/kubernetes-sigs/multi-tenancy/releases/download/hnc-{HNC_VERSION}/kubectl-hns_${HNC_PLATFORM} -o ./kubectl-hns
$ chmod +x ./kubectl-hns

And run the following command to confirm help message is shown.

$ kubectl hns

Generated YAML

I've applied to our lab GKE cluster (1.15) by following the release note instruction.

$ HNC_VERSION=v0.5.2-rc1
$ kubectl apply -f https://github.com/kubernetes-sigs/multi-tenancy/releases/download/hnc-${HNC_VERSION}/hnc-manager.yaml

And run the following commands to confirm timeoutSeconds configuration is properly configured.

$ kubectl get validatingwebhookconfiguration hnc-validating-webhook-configuration -o yaml

[adrianludwin]

Great, thanks! I'll call that "confirmed" and we'll release 0.5.2 in a day or two (there's one more change I'd like to get in).

/close

[k8s-ci-robot]

@adrianludwin: Closing this issue.

In response to this:

Great, thanks! I'll call that "confirmed" and we'll release 0.5.2 in a day or two (there's one more change I'd like to get in).

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.