This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
Change subnamespace object to SubnamespaceAnchor #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a breaking change; the HierarchicalNamespace object is replaced with the SubnamespaceAnchor object. Otherwise, there are no changes (including to the UX). Tested: manual + all tests continue to pass
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
/assign @yiqigao217 |
|
If this is a breaking change, shouldn't we at a minimum rev to |
|
We've made breaking changes in "v1alpha1" in every version of HNC up until
now. We should probably be more cautious in the future (e.g. once we move
to our own repo and start having real users) but personally I'd like to
take advantage of the fact that, AFAIK, no-one will be badly impacted if we
do this today.
…On Mon, May 11, 2020 at 10:54 AM Ryan Bezdicek ***@***.***> wrote:
If this is a breaking change, shouldn't we at a minimum rev to v1alpha2?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#704 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE43PZCAR3JMPX3PE5IBSZTRRAGR3ANCNFSM4M5L4MMA>
.
|
|
Yeah, I was just thinking about the (hopefully soon) move to a real repo and wondered when we should start following those practices. I'm good with waiting until then. |
|
sgtm!
…On Mon, May 11, 2020 at 11:35 AM Ryan Bezdicek ***@***.***> wrote:
Yeah, I was just thinking about the (hopefully soon) move to a real repo
and wondered when we should start following those practices. I'm good with
waiting until then.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#704 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE43PZG2AMYIS7RV7R3ILI3RRALNVANCNFSM4M5L4MMA>
.
|
|
/lgtm |
k8s-ci-robot
added
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianludwin, yiqigao217 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change; the HierarchicalNamespace object is replaced
with the SubnamespaceAnchor object. Otherwise, there are no changes
(including to the UX).
Tested: manual + all tests continue to pass