Skip to content
This repository has been archived by the owner on Jun 26, 2023. It is now read-only.

[VC] alter vc name #741

Merged
merged 3 commits into from
May 20, 2020
Merged

[VC] alter vc name #741

merged 3 commits into from
May 20, 2020

Conversation

zhuangqh
Copy link
Contributor 

    api definition change

    1. alter VC CRD name from Virtualcluster to VirtualCluster
    2. remove ClusterVersionHistory from VC status

Signed-off-by: zhuangqh zhuangqhc@gmail.com

fixes: #728

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 20, 2020
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 20, 2020
@zhuangqh
add script to update codegen
d19f6b3 
Signed-off-by: zhuangqh <zhuangqhc@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 20, 2020
@zhuangqh
api definition change
279e3a6 
1. alter VC CRD name from Virtualcluster to VirtualCluster
2. remove ClusterVersionHistory from VC status

Signed-off-by: zhuangqh <zhuangqhc@gmail.com>
@zhuangqh
update document
44be587 
Signed-off-by: zhuangqh <zhuangqhc@gmail.com>
@Fei-Guo
Copy link
Contributor

Fei-Guo commented May 20, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fei-Guo, zhuangqh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 03244c2 into kubernetes-retired:master May 20, 2020
@christopherhein
Copy link
Contributor

AWESOME!!!! thanks for doing this @zhuangqh

@Fei-Guo Fei-Guo mentioned this pull request May 20, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adohe-zz adohe-zz Awaiting requested review from adohe-zz

@resouer resouer Awaiting requested review from resouer

Assignees

@Fei-Guo Fei-Guo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[VC]: Renaming Virtualcluster -> VirtualCluster?
4 participants
@zhuangqh @Fei-Guo @k8s-ci-robot @christopherhein