Skip to content
This repository has been archived by the owner on Jun 26, 2023. It is now read-only.

[VC] update tenant master component to v1.16.x #807

Merged
merged 1 commit into from
Jun 17, 2020

Conversation

zhuangqh
Copy link
Contributor

Signed-off-by: zhuangqh zhuangqhc@gmail.com

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 16, 2020
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 16, 2020
@christopherhein
Copy link
Contributor

christopherhein commented Jun 16, 2020

How do the image registries get updated?

I'm seeing both registry.cn-hangzhou.aliyuncs.com/virtualcluster/... and virtualcluster/....

@ShadowJonathan
Copy link

How do the image registries get updated?

I'm seeing both registry.cn-hangzhou.aliyuncs.com/virtualcluster/... and virtualcluster/....

This, i also cannot access registry.cn-hangzhou.aliyuncs.com, it times out for me.

@christopherhein
Copy link
Contributor

I wonder if we should have the same registry domain for all images that come from the virtualcluster project. I know for myself I usually build all the images and push them to my own registry then have to change all the paths manually, at least until we have #738 when we can use kustomize set image name=foobar.

@Fei-Guo
Copy link
Contributor

Fei-Guo commented Jun 16, 2020

I wonder if we should have the same registry domain for all images that come from the virtualcluster project. I know for myself I usually build all the images and push them to my own registry then have to change all the paths manually, at least until we have #738 when we can use kustomize set image name=foobar.

Yes, we should. @zhuangqh, we'd better change images to docker hub ones for loadbalancer type of clusterversion.

Signed-off-by: zhuangqh <zhuangqhc@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 17, 2020
@zhuangqh
Copy link
Contributor Author

fixed. good catch @Fei-Guo @christopherhein

@Fei-Guo
Copy link
Contributor

Fei-Guo commented Jun 17, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fei-Guo, zhuangqh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 783dee1 into kubernetes-retired:master Jun 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants