Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

Standalone k8s broker? #316

Closed
jmcarp opened this issue Jan 30, 2017 · 8 comments
Closed

Standalone k8s broker? #316

jmcarp opened this issue Jan 30, 2017 · 8 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Milestone

Comments

@jmcarp
Copy link

jmcarp commented Jan 30, 2017

I'm wondering if the helm-powered k8s broker in https://github.com/kubernetes-incubator/service-catalog/tree/master/contrib/pkg/broker is or might become a replacement for https://github.com/18f/kubernetes-broker, which my team is currently using to broker k8s resources to cloud foundry applications. I had a few questions about this:

  • Could this package be broken out into a separate repository to make it easier to find? I only stumbled across it by chance.
  • It looks like I'd need to run both the broker and the service registry, with the broker querying the registry to figure out which services it offers. I'm wondering why these are separate applications--in my experience with service brokers in cf-land, the catalog often lives in the broker app and is configured by passing a file that can be checked into source control, like this.
  • WDYT about getting bind credentials using configmaps or similar, as in https://github.com/deis/steward/blob/master/doc/HELM_MODE.md#bind-and-unbind-operations ? I assume you're familiar, since it looks like both packages come from deis 😄. It looks like the current logic requires the chart notes to be valid yaml and nothing else.

Also, if the broker package is far enough along that you're accepting outside contributions, I'd be happy to give it a try and potentially start contributing--let me know!

@vaikas
Copy link
Contributor

vaikas commented Feb 8, 2017

#1 : it could, our thinking was that at least for now it would be nice for everything to 'just come up' so you could build, push and get things up and running without different repos.
#2 : The thinking behind this is that a single broker [helm broker in this case], could dynamically support different kinds of ServiceClasses simply by you adding a schema / templates and then that broker would be able to instantiate them. So, there's kind of two catalogs there, broker / registry catalog, and the Service Catalog, which in turn exposes what brokers support. Hope that makes sense.
#3 : are you thinking about how to get bindings from the broker [they come in a form of an API] or how the Controller manifests them for consumption? If latter, then yes, the creds get stuffed into secrets [and/or later into configmaps is the plan]

@pmorie
Copy link
Contributor

pmorie commented Mar 1, 2017

@jmcarp We can definitely discuss splitting out some of the brokers under contrib into separate repositories once we get our MVP into shape. I would prefer to have folks remain focused on MVP for the moment. Does that work for you? Thanks a lot for your interest and apologies for the latency responding.

@pmorie pmorie added this to the Later milestone Mar 1, 2017
@arschles arschles removed this from the Later milestone Apr 3, 2017
@duglin duglin added this to the Post-1.0.0 milestone Jul 9, 2017
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 21, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 21, 2019
@jberkhahn jberkhahn removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label May 23, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 21, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 20, 2019
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

8 participants