Skip to content
This repository has been archived by the owner on Jan 17, 2020. It is now read-only.

make it work 1.12+ kube-apiserver --secure-port flag #62

Merged
merged 1 commit into from
Dec 14, 2018

Conversation

mengqiy
Copy link
Contributor

@mengqiy mengqiy commented Dec 12, 2018

Starting from 1.12, kube-apiserver not longer accept --secure-port=0.
So we should make it use a random port.

--secure-port int     Default: 6443
The port on which to serve HTTPS with authentication and authorization.It cannot be switched off with 0.

Ref: https://v1-12.docs.kubernetes.io/docs/reference/command-line-tools-reference/kube-apiserver/

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 12, 2018
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 12, 2018
@mengqiy
Copy link
Contributor Author

mengqiy commented Dec 12, 2018

/cc @apelisse

@apelisse
Copy link

That should be OK ...
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2018
@mengqiy
Copy link
Contributor Author

mengqiy commented Dec 13, 2018

Can someone approve it please?

@mengqiy
Copy link
Contributor Author

mengqiy commented Dec 14, 2018

@apelisse @hoegaarden

@apelisse
Copy link

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, mengqiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2018
@k8s-ci-robot k8s-ci-robot merged commit d348cb1 into kubernetes-retired:master Dec 14, 2018
@mengqiy mengqiy deleted the secure_port branch December 14, 2018 21:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants