bugfix: silence metrics volume devices logic #826
Conversation
k8s-ci-robot
added
kind/bug
pkg/metric/utils.go
Outdated
| @@ -201,11 +201,12 @@ func getDeviceByVolumeID(pvName, volumeID string) (device string, err error) { | |||
| } | |||
|
|
|||
| if device, err = getDeviceBySymlink(volumeID); err != nil { | |||
| // strange logic... ignore findmnt error | |||
There was a problem hiding this comment.
PolarFS maybe using volumeDevices?
There was a problem hiding this comment.
OK, but we still don't know why this vol_data.json is not cleaned up and referring to an non-exists disk. Anyway, vol_data.json should be the implementation detail of kubelet, which we should not rely on. I think we may get rid of reading vol_data.json in the future.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: huww98, mowangdk, tydra-wang The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/M
mowangdk
force-pushed
the
bugfix/metrics_volume_device_logic_silence
branch
from
6bba13b
to
5f8d212
Compare
What type of PR is this?
/kind bug
What this PR does / why we need it:
Solve "Get dev name by diskID xxxx failed, err:getDeviceByVolumeIDxxxxx with error Failed to run cmd: findmnt" error
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?
None
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: