-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
always force delete disk snapshot #856
always force delete disk snapshot #856
Conversation
Hi @huww98. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
If there are some disks created from a snapshot, that snapshot cannot be deleted without `force`. Because the disks cannot be re-initialized then. We don't support re-init, so just do force delete unconditionally. Still preserve the snapshot tag force.delete.snapshot.k8s.aliyun.com, for human operator, possible downgrade, etc. Although we will not read it any more.
ef1f9c6
to
b7d5856
Compare
As requested by @mowangdk , we still keep the tag |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: huww98, mowangdk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
If there are some disks created from a snapshot, that snapshot cannot be deleted without
force
. Because the disks cannot be re-initialized then. We don't support re-init, so just do force delete unconditionally.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: