disk: add tags to ECS snapshot

[huww98]

What type of PR is this?

/kind feature
/kind design

What this PR does / why we need it:

Automatically add 3 more tags to every ECS snapshot:

• ack.aliyun.com: current ACK cluster ID
• csi.alibabacloud.com/snapshot/name
• csi.alibabacloud.com/snapshot/namespace

Also allow users to add custom tags.
User should specify "snapshotTags/tagKey: tagValue" in VolumeSnapshotClass to add tag "tagKey: tagValue". This design allows arbitrary keys and values, compared with the design of disk tags, which does not allow "," in key or value, or ":" in key.

If this design works fine, we can also implement this on disk tags.

Which issue(s) this PR fixes:

Fixes #900

Special notes for your reviewer:

Does this PR introduce a user-facing change?

3 more tags are added to every new ECS snapshot:
- ack.aliyun.com: current ACK cluster ID
- csi.alibabacloud.com/snapshot/name
- csi.alibabacloud.com/snapshot/namespace
You can also add custom tag "tagKey: tagValue" by specifying "snapshotTags/tagKey: tagValue" in VolumeSnapshotClass.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

Hi @huww98. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[huww98]

@shusaan How do you like this design?

[shusaan]

@shusaan How do you like this design?
Thank you for this.

it is good just for confirm it will support multiple custom tags, like

SnapshotTags: "team:dev,user:david"

[huww98]

it is good just for confirm it will support multiple custom tags, like

SnapshotTags: "team:dev,user:david"

@shusaan with current design, this is written as:

snapshotTags/team: dev
snapshotTags/user: david

[shusaan]

it is good just for confirm it will support multiple custom tags, like
SnapshotTags: "team:dev,user:david"

@shusaan with current design, this is written as:

snapshotTags/team: dev
snapshotTags/user: david

This one is good but one suggestion, i think if you apply this pattern SnapshotTags: "team:dev,user:david" then it is same as disk tags and tags property will be same for disk and snapshot as well.
ref link,
https://github.com/kubernetes-sigs/alibaba-cloud-csi-driver/blob/master/examples/disk/diskTags/storageclass.yaml

[huww98]

Yes, I'm aware of the diskTags. but that home-made syntax does not have proper escape mechanism. i.e., we have no way to specify tag user: "david,bob". To avoid such corner cases, I made this new design, leaving all the escaping to standard yaml parser. I think this is simpler for users and more future-proof.

If this look OK to @mowangdk , I will also implement this on StorageClass.

[shusaan]

@mowangdk any ETA for this please?

[shusaan]

@mowangdk any update please

[mowangdk]

@mowangdk any update please

we have got a large pr ready to merge , this pr will merged after that. and it may have an impact on the existing logic, and we'll probably merge it around January of next year.

[shusaan]

@mowangdk any update please

[mowangdk]

/ok-to-test

[mowangdk]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huww98, mowangdk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mowangdk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[shusaan]

Thank you @mowangdk can you please share expected release of this.