Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

containerized ossfs mount #918

Merged
merged 39 commits into from
Dec 1, 2023
Merged

containerized ossfs mount #918

merged 39 commits into from
Dec 1, 2023

Conversation

tydra-wang
Copy link
Contributor

What type of PR is this?

/kind feature
/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

tydra-wang and others added 30 commits November 30, 2023 20:48
@tydra-wang
feat: add ossfs Dockerfile
a44432e
@tydra-wang
add ContainerizedFuseMounter implementation
f47785c
@tydra-wang
feat: refactor oss plugin to use containerized mounter implementation
bd7c338
@tydra-wang
ossfs: check if fuse container image configured
5284980
@tydra-wang
feat: containerized ossfs working properly
df04301
@tydra-wang
perf: ossfs containerized mounter
a8d2fb7
@tydra-wang
fix: volume id may be invalid string in fuse mounter pod name
6e32d0d
@tydra-wang
build: remove ossfs installation stuffs in csi image
a72c3ab
@tydra-wang
cleanup(oss): remove IsLastSharedVol
f9a7e87
@tydra-wang
build: add arm64 support in ossfs Dockerfile
1102270
@tydra-wang
cleanup(build): csi-plugin image need not copy ossfs-arm packages
68bf37f
@tydra-wang
fix(arm): csiplugin-connector not installed correctly
f7a9a83
@tydra-wang
perf: don't clean exited fuse pod immediately & avoid hash conflict
d227c63
@tydra-wang
perf(oss): set default ossfs image & fuse pods restart on failure
a276b9b
@tydra-wang
cleanup(build): refactor Dockerfiles
021ab19
@tydra-wang
cleanup
ba6e04d
@tydra-wang
fix(oss): fuse pods leak when useSharedPath is set false
7a9dee8
@tydra-wang
feat(oss): set default fuse pod memory request
2354015
@tydra-wang
chore: retrieve ossfs registry from the DEFAULT_REGISTRY env variable
41c0c3a
@tydra-wang
perf(oss): ossfs fuse pods access credentials by mounting secret
19e4779
@tydra-wang
cleanup: use json.Marshal to generate secret patch
ae8c21c
@tydra-wang
fix(oss): do not fatal if csi-plugin configmap not found
042a024
@tydra-wang
perf(fuse-mounter): avoid hash conflict when cleaning up pods
851d26c
@tydra-wang
chore: update rbac configs for ossfs fuse mounter
42b8783
@AlbeeSo @tydra-wang
feat: upgrate ossfs version to 1.88.2
10e1eb6
@AlbeeSo @tydra-wang
modified default ossfs image to 1.88.2 version
92dbf72
@tydra-wang
fix rebase
3e7acfb
@tydra-wang
fix(oss): ossfs pod should tolerate all taints
9a758c9
@AlbeeSo @tydra-wang
support mime-types
6caf9e5
@AlbeeSo @tydra-wang
ossfs support mime_types_file
b40d3fb
@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 30, 2023
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 30, 2023
@tydra-wang tydra-wang marked this pull request as ready for review December 1, 2023 03:09
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 1, 2023
huww98
huww98 reviewed Dec 1, 2023
View reviewed changes
Copy link
Contributor

@huww98 huww98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also update build/multi-private similar to build/multi?

build/amd can be removed IMO, we will not maintain it any more.

huww98
huww98 suggested changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@huww98 huww98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add DEFAULT_REGISTRY variable to deploy/nonecs/csi-{plugin,provisioner}.yaml, or it will panic in RetryGetMetaData.

pkg/mounter/ossfs.go Outdated Show resolved Hide resolved
huww98
huww98 reviewed Dec 1, 2023
View reviewed changes
build/fuse-clients/ossfs/Dockerfile
@@ -0,0 +1,4 @@
FROM registry.cn-hangzhou.aliyuncs.com/acs/alinux:3-update
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using registry.eu-west-1.aliyuncs.com/acs/alinux:3-update in multi/Dockerfile.multi, should we be consistent here?

Copy link
Contributor

@mowangdk mowangdk Dec 1, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image localcache could be garbage collected, IMO, image should be kept as small as possible

huww98
huww98 suggested changes Dec 1, 2023
View reviewed changes
pkg/mounter/fuse_containerized_mounter.go Outdated Show resolved Hide resolved
pkg/oss/utils_test.go Show resolved Hide resolved
@mowangdk
Copy link
Contributor

mowangdk commented Dec 1, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 1, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mowangdk, tydra-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8aefe93 into kubernetes-sigs:master Dec 1, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huww98 huww98 huww98 requested changes

@AlbeeSo AlbeeSo AlbeeSo left review comments

@mowangdk mowangdk Awaiting requested review from mowangdk

Assignees

@mowangdk mowangdk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tydra-wang @k8s-ci-robot @mowangdk @huww98 @AlbeeSo