Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disk: refined volume count detection #960

Merged
merged 3 commits into from
Jan 29, 2024
Merged

disk: refined volume count detection #960

merged 3 commits into from
Jan 29, 2024

Conversation

huww98
Copy link
Contributor

@huww98 huww98 commented Jan 25, 2024 •
edited

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

Volume count detection now also works for static PV.
We detect whether a disk is managed by us by reading k8s node resource, instead of disk tag.

This makes OpenAPI access on node mandatory. We cannot startup if we cannot access OpenAPI.
set DISK_ALLOW_ALL_TYPE env to skip this.

Also makes KUBE_NODE_NAME env mandatory.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

action required: make sure you have KUBE_NODE_NAME env set for plugin Pod.
action required: make sure `ecs:DescribeInstanceTypes` and `ecs:DescribeDisks` RAM permission is granted to plugin.
a new tag csi.alibabacloud.com/volume-name is added to EBS disk

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 25, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @huww98. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 25, 2024
@huww98 huww98 force-pushed the disk-volume-count branch 3 times, most recently from 8e30dbe to 41e2c58 Compare January 26, 2024 10:57
@huww98
disk: refined volume count detection
84e77aa 
Volume count detection now also works for static PV.
We detect whether a disk is managed by us by reading k8s node resource, instead of disk tag.

This makes OpenAPI access on node mandatory by default. We cannot startup if we cannot access OpenAPI.
set DISK_ALLOW_ALL_TYPE env to skip this.

Also makes KUBE_NODE_NAME env mandatory.
@huww98
enable auto-detection of volume count by default
268dc98
@huww98
support for more volumeName
cc1bf3d 
add a new disk tag csi.alibabacloud.com/volume-name
only set diskName if we are sure it is vaild

to comply with CSI spec and pass CSI-sanity test
@huww98 huww98 marked this pull request as ready for review January 26, 2024 11:45
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 26, 2024
@mowangdk
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huww98, mowangdk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit e9b2975 into kubernetes-sigs:master Jan 29, 2024
7 checks passed
@huww98 huww98 deleted the disk-volume-count branch January 29, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mowangdk mowangdk Awaiting requested review from mowangdk

Assignees

@mowangdk mowangdk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@huww98 @k8s-ci-robot @mowangdk