-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support installation through homebrew on mac #129
Comments
@pwittrock: I've recently come across this fantastic project. If contributions are welcome, feel free to assign it to me and I'll look into it! |
Consider is assigned. Just invited you as a collaborator, which allow me to actually assign it to you. |
Cool, thanks for bringing me on board! |
@pwittrock, let's have a discussion over the scope of this issue after I've done some research. Creating support for installation via homebrew involves creating a formula. A formula points to a specific source code archive and defines methods for installation and testing. A formula can be part of the official homebrew-core project, which allows convenient installation via, e.g., The alternative is to provide our formula in a tap, a third party repo for formulae. Since we own the tap, we can update the formulae at any time (e.g. for version bumps). In this case, an installation via A consolidated approach would store the tap in this repository, by convention under a directory named
Preferences? Thoughts? |
I like the third approach. The project is just in its infancy, so minimizing overhead and optimizing for making it easy to push lots of releases makes sense to me. It is probably not worth creating another repo for the formula with the project at this stage. |
While debugging the homebrew formula, I came across the following issue:
I am wondering why go does not find the dependency package in the
Also, the
I've also checked that
|
I think your directory structure may be off. Go expects the go to be under If your GOPATH is I am not sure why it cannot find the vendor, but it maybe that it is looking for the vendor directory under |
Thanks for your feedback @pwittrock, I'll look into your suggestions! |
@metmajer FYI, I have been starting to do some work to integrate Bazel support for faster builds. I also changed how the glide.tar.gz is done locally instead of through glide. I've tested the changes quite a bit, but there is still a chance I broke something. |
FYI, i introduced building with bazel which is much faster once you have bazel installed. go run cmd/apiserver-builder-release/main.go vendor --version 0.1-alpha.19 && \
go run cmd/apiserver-builder-release/main.go build --version 0.1-alpha.19 --bazel |
Awesome, I'll make sure this is also reflected in the Makefile. I'm quite a bit busy atm, but will follow up very soon. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.
The text was updated successfully, but these errors were encountered: