Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multiple grpc dial options for agent -> server connection #153

Merged
merged 1 commit into from Oct 26, 2020
Merged

Support multiple grpc dial options for agent -> server connection #153

merged 1 commit into from Oct 26, 2020

Conversation

Jefftree
Copy link
Member

grpc supports multiple dial options but currently agent -> server dials (cmd/agent/main.go) only supports 1 dial option as a parameter. Refactor the code to support multiple.

This might be helpful for #152

/assign @cheftako

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 16, 2020
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 16, 2020
@Avatat
Copy link
Contributor

Avatat commented Oct 21, 2020

I sit to implementing keepalive for the agent, and now I understand your change ;)
I will wait for a merge and then start implementing the keepalive option in the agent.

cheftako
cheftako reviewed Oct 23, 2020
View reviewed changes
pkg/agent/clientset.go Outdated Show resolved Hide resolved
cheftako
cheftako reviewed Oct 23, 2020
View reviewed changes
pkg/agent/clientset.go Outdated
@@ -110,7 +110,7 @@ type ClientSetConfig struct {
AgentID string
SyncInterval time.Duration
ProbeInterval time.Duration
DialOption grpc.DialOption
DialOption []grpc.DialOption
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here? Public so requires a bit more thought.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be no problem renaming this since the agent is a standalone binary and is not imported anywhere.

@cheftako
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2020
@cheftako
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, Jefftree

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2020
@k8s-ci-robot k8s-ci-robot merged commit 408d5bb into kubernetes-sigs:master Oct 26, 2020
@Jefftree Jefftree deleted the multiple-grpc-options branch December 7, 2021 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheftako cheftako cheftako left review comments

@dberkov dberkov Awaiting requested review from dberkov

@Sh4d1 Sh4d1 Awaiting requested review from Sh4d1

Assignees

@cheftako cheftako

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Jefftree @Avatat @cheftako @k8s-ci-robot