Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conformance gate failure due to alpha endpoint getStoragemigrationAPIGroup #859

Closed
heyste opened this issue Apr 3, 2024 · 2 comments
Closed
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@heyste
Copy link
Member

heyste commented Apr 3, 2024

Conformance progress for 1.30 shows there is there an endpoint getStoragemigrationAPIGroup that is has been promoted without tests 1 This endpoint has been added already been added to pending_eligible_endpoints.yaml 2 which means conformance coverage is still at 100% 3

The conformance gate 4 is failing due to the above endpoint been listed as untested.

==================
UNTESTED ENDPOINTS
getStoragemigrationAPIGroup
==================
ERROR: You have 1 untested endpoints
==================

AFAICT pending_eligible_endpoints.yaml is only used for the website and not used by snoopdb, which does uses ineligible_endpoints.yaml 5 6 A possible solution is to use the contents of pending_eligible_endpoints.yaml to filter any resulting "untested endpoints" so that the conformance gate can pass.

Also, its misleading to have this alpha endpoint shown on either the list of "Promoted without Tests" 1 or shown on the Conformance Progress Charts 7

~/go/src/k8s.io/kubernetes$ grep apis/storagemigration api/openapi-spec/swagger.json
    "/apis/storagemigration.k8s.io/": {
    "/apis/storagemigration.k8s.io/v1alpha1/": {
    "/apis/storagemigration.k8s.io/v1alpha1/storageversionmigrations": {
    "/apis/storagemigration.k8s.io/v1alpha1/storageversionmigrations/{name}": {
    "/apis/storagemigration.k8s.io/v1alpha1/storageversionmigrations/{name}/status": {
    "/apis/storagemigration.k8s.io/v1alpha1/watch/storageversionmigrations": {
    "/apis/storagemigration.k8s.io/v1alpha1/watch/storageversionmigrations/{name}": {
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 2, 2024
@heyste
Copy link
Member Author

heyste commented Jul 15, 2024

@heyste heyste closed this as completed Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

3 participants