Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

routing.http2.enabled does not work #1059

Closed
eddycharly opened this issue Nov 1, 2019 · 8 comments
Closed

routing.http2.enabled does not work #1059

eddycharly opened this issue Nov 1, 2019 · 8 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@eddycharly
Copy link

Setting routing.http2.enabled=false in the alb attributes annotation does not work correctly.
Sometimes i set it to true, and the alb has http2 disabled.
Sometimes i set it to false, and the alb has http2 enabled.

In any case, when i succeed to set it to false, http2 is disabled for a few minutes and is reactivated a few minutes later.

Maybe a sort of cache issue...

Below are the controller logs, notice how it is reset to true after a while though i didn't change the ingress annotations :

I1101 18:55:12.539522       1 attributes.go:144] ingress/internet: Modifying ELBV2 attributes to [{    Key: "routing.http2.enabled",    Value: "true"  }].
I1101 19:23:09.220610       1 attributes.go:144] ingress/internet: Modifying ELBV2 attributes to [{    Key: "routing.http2.enabled",    Value: "false"  }].
I1101 19:55:10.642617       1 attributes.go:144] ingress/internet: Modifying ELBV2 attributes to [{    Key: "routing.http2.enabled",    Value: "true"  }].
I1101 20:42:08.725861       1 attributes.go:144] ingress/internet: Modifying ELBV2 attributes to [{    Key: "routing.http2.enabled",    Value: "false"  }].
I1101 20:55:12.355644       1 attributes.go:144] ingress/internet: Modifying ELBV2 attributes to [{    Key: "routing.http2.enabled",    Value: "true"  }].
@eddycharly
Copy link
Author

eddycharly commented Nov 1, 2019

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 1, 2019
@eddycharly
Copy link
Author

/woof

@k8s-ci-robot
Copy link
Contributor

@eddycharly: dog image

In response to this:

/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gws
Copy link

gws commented Jan 2, 2020

This is happening consistently to me as well, using v1.1.4, but with a different annotation.

When I first set the annotation alb.ingress.kubernetes.io/load-balancer-attributes: idle_timeout.timeout_seconds=300, nothing happened.

Later, I set alb.ingress.kubernetes.io/load-balancer-attributes: idle_timeout.timeout_seconds=360 (note the different timeout value), and the following was logged by the controller:

Modifying ELBV2 attributes to [{    Key: "idle_timeout.timeout_seconds",    Value: "300"  }].

I then set alb.ingress.kubernetes.io/load-balancer-attributes: idle_timeout.timeout_seconds=300 once more and the following was logged:

Modifying ELBV2 attributes to [{    Key: "idle_timeout.timeout_seconds",    Value: "360"  }].

Further testing yielded the same results - the previous set of attributes are getting synced, not the current set of attributes.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 1, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 1, 2020
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

4 participants