Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] fix multiple bugs #1484

Merged
merged 2 commits into from
Oct 12, 2020
Merged

[v2] fix multiple bugs #1484

merged 2 commits into from
Oct 12, 2020

Conversation

M00nF1sh
Copy link
Collaborator

@M00nF1sh M00nF1sh commented Oct 10, 2020

  1. Added a ruleOptimizer to optimize listener rules:
    1. infinite redirect rules will be omitted.
    2. future rules overshadowed by a redirect rule will be omitted.
    3. Fix HTTPs redirect support: [v2] HTTP Redirects Don't Work #1475
  2. Fix the resourceID for listeners rules to include listener Port as well.
    1. Fix HTTPs rule issue: [v2] no rules on HTTPS listener #1485
  3. Fix the inbound-cidr merge logic to align with docs:
    1. allow same inbound cidr been configured on multiple Ingress as long as the value is same.
    2. Fixes [v2] Defining inbound-cidrs on multiple Ingresses do not merge correctly #1486
  4. Fix an edge case where targetGroup is deleted manually and cause securityGroup rules not cleaned up.
  5. Optimize the equality check for RedirectActionConfig, which helps to avoid unnecessary rule reconciles
  6. removes aws/errors package.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: M00nF1sh
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 10, 2020
@somdoron
Copy link

@M00nF1sh any chance #1485 is related?

@M00nF1sh
Copy link
Collaborator Author

@somdoron yes, #1485 will be fixed with this PR as well

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 12, 2020
@M00nF1sh M00nF1sh changed the title fix bugs [v2] fix multiple bugs Oct 12, 2020
@M00nF1sh M00nF1sh merged commit 40a71f6 into kubernetes-sigs:v2_ga Oct 12, 2020
Timothy-Dougherty pushed a commit to adammw/aws-load-balancer-controller that referenced this pull request Nov 9, 2023
* fix bugs

* fix inbound-cidr merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants