Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wait readiness delay for liveness to start #609

Merged
merged 1 commit into from
Sep 12, 2018

Conversation

r0fls
Copy link

@r0fls r0fls commented Sep 12, 2018

Currently the liveness probe will start before the readiness probe has completed. This will ensure at least the readiness probe timeout is finished before starting the liveness probe.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 12, 2018
@bigkraig
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 12, 2018
@bigkraig
Copy link

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigkraig, r0fls

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2018
@coveralls
Copy link

coveralls commented Sep 12, 2018

Coverage Status

Coverage remained the same at 25.268% when pulling 24795c9 on r0fls:helm-liveness-delay into 0c47954 on kubernetes-sigs:master.

@k8s-ci-robot k8s-ci-robot merged commit afe7a19 into kubernetes-sigs:master Sep 12, 2018
bigkraig pushed a commit that referenced this pull request Oct 1, 2018
wait readiness delay for liveness to start
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants