Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configurable readiness delay in helm chart #611

Merged

Conversation

r0fls
Copy link

@r0fls r0fls commented Sep 13, 2018

This was incorrect .Values.readinessProbeTimeout as it refers the http timeout. This is to prevent the liveness probe from beginning before the readiness probe has completed. More context here: kubernetes/kubernetes#27114

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 13, 2018
@bigkraig
Copy link

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 13, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigkraig, r0fls

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2018
@k8s-ci-robot k8s-ci-robot merged commit df5bc6a into kubernetes-sigs:master Sep 13, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 25.328% when pulling 500c08b on r0fls:configureable-readiness-probe into 53a9e2c on kubernetes-sigs:master.

bigkraig pushed a commit that referenced this pull request Oct 1, 2018
configurable readiness delay in helm chart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants