Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up root directory #701

Merged
merged 1 commit into from Oct 30, 2018
Merged

clean up root directory #701

merged 1 commit into from Oct 30, 2018

Conversation

M00nF1sh
Copy link
Collaborator

changes done:

  1. code-of-conduct must be named by CODE_OF_CONDUCT(can be verified by insights/community tab)
  2. move github related files like README/CONTRIBUTING to docs(both rootDir/docs/.github folder are supported by github)
  3. add subfolders in docs to ease future doc adding

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: M00nF1sh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 30, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 44.083% when pulling 2ea4235 on M00nF1sh:patch-structure into ea007e5 on kubernetes-sigs:master.

@bigkraig
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2018
@k8s-ci-robot k8s-ci-robot merged commit 1d086d0 into kubernetes-sigs:master Oct 30, 2018
cj-taylor added a commit to cj-taylor/aws-alb-ingress-controller that referenced this pull request Nov 2, 2018
@cj-taylor
fix(docs): Updated link to example iam-policy that was moved per kube…
da65f1a 
…rnetes-sigs#701.
@cj-taylor cj-taylor mentioned this pull request Nov 2, 2018
Merged
k8s-ci-robot added a commit that referenced this pull request Nov 5, 2018
@k8s-ci-robot
Merge pull request #717 from cj-taylor/update-urls-to-resources
4459b01 
fix(docs): Updated link to example iam-policy that was moved per #701.
@M00nF1sh M00nF1sh deleted the patch-structure branch November 5, 2018 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigkraig bigkraig Awaiting requested review from bigkraig

Assignees

@bigkraig bigkraig

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@M00nF1sh @k8s-ci-robot @coveralls @bigkraig