Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Updated link to example iam-policy that was moved per #701. #717

Merged

Conversation

cj-taylor
Copy link

@cj-taylor cj-taylor commented Nov 2, 2018

Was following the walkthrough guide for configuration of kube2iam and found this link to be stale per #701.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 2, 2018
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 2, 2018
@coveralls
Copy link

coveralls commented Nov 2, 2018

Coverage Status

Coverage remained the same at 44.083% when pulling da65f1a on cj-taylor:update-urls-to-resources into 438c750 on kubernetes-sigs:master.

@cj-taylor
Copy link
Author

I signed it

@cj-taylor cj-taylor changed the title fix(docs): Updated link to example iam-policy that was moved per https://github.com/kubernetes-sigs/aws-alb-ingress-controller/pull/701. fix(docs): Updated link to example iam-policy that was moved per #701. Nov 2, 2018
@M00nF1sh
Copy link
Collaborator

M00nF1sh commented Nov 2, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 2, 2018
@M00nF1sh
Copy link
Collaborator

M00nF1sh commented Nov 5, 2018

@cj-taylor hi, did you sign the CLA using your email cj-taylor@outlook.com?
=.=seems the CLA check still fails..

@cj-taylor
Copy link
Author

@M00nF1sh, yeah, just went through the signing process again, it's via cj-taylor@outlook.com.

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 5, 2018
@M00nF1sh
Copy link
Collaborator

M00nF1sh commented Nov 5, 2018

/lgtm
/approve

Thanks for fixing this 👍

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cj-taylor, M00nF1sh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2018
@k8s-ci-robot k8s-ci-robot merged commit 4459b01 into kubernetes-sigs:master Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants