[release-1.3] Fix windows NodePublish failing because mount target doesn't exist #1083
Conversation
k8s-ci-robot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/M
| This example shows how to create a EBS volume and consume it from a Windows container dynamically. | ||
|
|
||
|
|
||
| ## Prerequisites | ||
|
|
||
| 1. A 1.18+ Windows node. Windows support has only been tested on 1.18 EKS Windows nodes. https://docs.aws.amazon.com/eks/latest/userguide/windows-support.html | ||
| 2. [csi-proxy](https://github.com/kubernetes-csi/csi-proxy) v1.0.0+ installed on the Windows node. | ||
| 3. An image of the driver built for Windows. It can be built and pushed with the command `TAG=$MY_TAG REGISTRY=$MY_REGISTRY make all-push` where `MY_TAG` refers to the image tag to push and `MY_REGISTRY` to the destination image registry like "XXXXXXXXXXXX.dkr.ecr.us-west-2.amazonaws.com" | ||
| 3. Driver v1.3.2 from GCR k8s.gcr.io/provider-aws/aws-ebs-csi-driver:v1.3.2. It can be built and pushed to another image registry with the command `TAG=$MY_TAG REGISTRY=$MY_REGISTRY make all-push` where `MY_TAG` refers to the image tag to push and `MY_REGISTRY` to the destination image registry like "XXXXXXXXXXXX.dkr.ecr.us-west-2.amazonaws.com" |
There was a problem hiding this comment.
| 3. Driver v1.3.2 from GCR k8s.gcr.io/provider-aws/aws-ebs-csi-driver:v1.3.2. It can be built and pushed to another image registry with the command `TAG=$MY_TAG REGISTRY=$MY_REGISTRY make all-push` where `MY_TAG` refers to the image tag to push and `MY_REGISTRY` to the destination image registry like "XXXXXXXXXXXX.dkr.ecr.us-west-2.amazonaws.com" | |
| 3. Driver v1.3.2 from GCR: `k8s.gcr.io/provider-aws/aws-ebs-csi-driver:v1.3.2`. | |
| It can be built and pushed to another image registry with the command `TAG=$MY_TAG REGISTRY=$MY_REGISTRY make all-push` where `MY_TAG` refers to the image tag to push and `MY_REGISTRY` to the destination image registry like "XXXXXXXXXXXX.dkr.ecr.us-west-2.amazonaws.com" |
| } | ||
|
|
||
| if !notMnt { | ||
| klog.V(4).Infof("NodePublishVolume: Target path %q is already mounted", target) | ||
| return !notMnt, nil | ||
| } | ||
|
|
||
| return !notMnt, err | ||
| // Do not return os.IsNotExist error. Other errors were handled above. It is |
There was a problem hiding this comment.
the idea is to ignore these because the caller should check that independently of whether target exists or ought to exist or not. since this is a cherry pick from master branch to release-1.3 I will submit a follow up fix to master branch to clean this up a bit. Like since now the function returns !notMnt, nil regardless of value of notMnt the above if statement can be simplified
There was a problem hiding this comment.
I edited PR description to say this is acherry-pick of #1081.
https://github.com/kubernetes-sigs/aws-ebs-csi-driver/pull/1087/files is PR to master trying to make it more understandable .
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/close will include this in v1.4.0, not sure another patch release of 1.3 will be needed. |
Is this a bug fix or adding new feature? /bug
What is this PR about? / Why do we need it?
cherry-pick of #1081.
small bugfix for windows.
waiting on #1079 first.
/hold
What testing is done?